Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS13 Support #391

Closed
Sehyris opened this issue Aug 29, 2019 · 7 comments · Fixed by #485
Closed

iOS13 Support #391

Sehyris opened this issue Aug 29, 2019 · 7 comments · Fixed by #485
Assignees
Labels
Bug This is clearly a bug and will be fixed in priority

Comments

@Sehyris
Copy link

Sehyris commented Aug 29, 2019

Are you going to provide a new version with iOS13 support? We are having issues after selecting a video, the video preview is not updated correctly

To Reproduce
Steps to reproduce the behavior:

  1. Open YPImagePicker controller
  2. Tap on Library tab
  3. Select a video, change the selected video to another from the grid
  4. See error

Expected behavior
After selecting a new video from the grid the preview should only show the selected video.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Device: iPhoneX
  • iOS 13 Beta
  • Xcode 11 Beta 6

Installation Type

  • Cocoapods

Additional context
It is failing on my project and also on demo example from the repository.

@kasnitski
Copy link

The same for me. Does anybody tried to fix it?

@Sehyris
Copy link
Author

Sehyris commented Sep 5, 2019

@kasnitski , @s4cha can you provide any input here?

@akshay-shah-dev
Copy link

i am capturing video OS 12.2 but camera not open just display black screen.

@s4cha
Copy link
Member

s4cha commented Jan 7, 2020

Hi @Sehyris The latest version supports iOS13 (dark mode and some fixes).
Concerning the "video preview is not updated correctly" This will hopefully be available later this week. iOS13 got us all very busy 😅

@s4cha
Copy link
Member

s4cha commented Jan 9, 2020

@Sehyris could you check if your issue is solved in the latest version https://github.com/Yummypets/YPImagePicker/releases/tag/4.2.0 ?
Thanks

@Sehyris
Copy link
Author

Sehyris commented Jan 9, 2020

Thanks @s4cha. I'm able to see the iOS13 fixes, however, the video preview is not working properly (it is better than before, after some seconds the overlapping view is removed). After switching between videos I can see the previous video in front of the selected video. Please see the attached images.
I'm using iPhone 8, OS 13.3 and library version 4.2.0.

Screen Shot 2020-01-09 at 10 43 13

Screen Shot 2020-01-09 at 10 47 43

@s4cha
Copy link
Member

s4cha commented Jan 10, 2020

@Sehyris Now I understand with the screenshot. I somehow thought preview was referring to the crop screen in which we had a known bug, my bad. This one shouldn't be to hard to fix. Will keep you posted :)

@s4cha s4cha self-assigned this Jan 10, 2020
@s4cha s4cha added Bug This is clearly a bug and will be fixed in priority UI labels Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is clearly a bug and will be fixed in priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants