Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol: Remove slot requirement for containers #6

Open
Yuffster opened this issue Aug 13, 2016 · 1 comment
Open

Protocol: Remove slot requirement for containers #6

Yuffster opened this issue Aug 13, 2016 · 1 comment
Milestone

Comments

@Yuffster
Copy link
Owner

Yuffster commented Aug 13, 2016

Protocols should be able to accept containers with either a label or a slot or both.

p = Protocol()
p.add_instrument('A', 'p10')
p.add_container('microplate.96', label="Ingredients")
p.add_container('microplate.96', label="Output")
p.transfer('Ingredients:A1', 'Output:A1')  # OK

p.transfer('A1:A1', 'B1:B1')  # Not OK; slots are unknown.

This will allow more dynamic Protocol concatenation, such as...

p1 = Protocol()
p1.add_instrument('A', 'p10')
p1.add_container('microplate.96', label="Ingredients")
p1.add_container('microplate.96', label="Output")
p1.transfer('Ingredients:A1', 'Output:A1')  # OK

p2 = Protocol()
p2.add_instrument('A', 'p10')
p2.add_container('microplate.96', label="Samples")
p2.add_container('microplate.96', label="Output")
p2.transfer('Samples:A1', 'Output:A1', ul=10)

p3 = Protocol()
p3.add_instrument('A', 'p10')
p3.add_container('microplate.96', label="Ingredients")
p3.add_container('microplate.96', label="Samples")
p3.add_container('microplate.96', label="Output")
p3.transfer('Ingredients:A1', 'Output:A1')
p3.transfer('Samples:A1', 'Output:A1', ul=10)

(p3 == p1 + p2)  # True
@Yuffster Yuffster modified the milestones: 1.0.0, 1.0 Aug 13, 2016
@Yuffster Yuffster changed the title Protocol: Remove slot requirement for containers. Protocol: Remove slot requirement for containers Aug 13, 2016
@Yuffster
Copy link
Owner Author

Yuffster commented Aug 13, 2016

This should also apply to exported JSON (requiring a change to the JSON format) and documented as its own issue #9.

{
    "containers": [
        {
            "name": "microplate.96",
            "label": "Ingredients",
            "slot": "A1"
        },
        {
            "name": "microplate.96",
            "label": "Output"
        }
    ]
}

@Yuffster Yuffster modified the milestones: 1.0, 1.2 Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant