Read report lengths from descriptor on Linux #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts input and output report lengths from the report descriptor by parsing it manually. Since the previous implementation did not parse the report lengths out of the report descriptor, any failure causes a fallback to the default 64 bytes in order to ensure backward compatibility.
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts input and output report lengths from the report descriptor
by parsing it manually.
Since the previous implementation did not parse the report lengths out
of the report descriptor, any failure causes a fallback to the default
64 bytes in order to ensure backward compatibility.
This has been tested manually with both a 64 byte and a 62 byte FIDO device.