Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup route happy-path only #9

Open
Yorkshireman opened this issue Sep 5, 2019 · 3 comments
Open

Signup route happy-path only #9

Yorkshireman opened this issue Sep 5, 2019 · 3 comments
Assignees

Comments

@Yorkshireman
Copy link
Owner

Yorkshireman commented Sep 5, 2019

Create a /signup route that creates a user with name, email and password_digest.

Code only happy path; success returns JWT containing database user id. However, include params validation.

@Yorkshireman Yorkshireman changed the title Signup route Signup route happy-path only Sep 5, 2019
@Yorkshireman Yorkshireman self-assigned this Sep 5, 2019
@Yorkshireman
Copy link
Owner Author

#10

@Yorkshireman
Copy link
Owner Author

Yorkshireman commented Sep 14, 2019

@Yorkshireman
Copy link
Owner Author

Need to raise unhappy path ticket off the back of this. Probably cover:

  • format error responses for:

    • missing params 400 response
    • some sort of params error when not nesting the request body under a user key
  • Error when attempting to signup with a duplicate email address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant