Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg 6.4 breaks FAQ block #13478

Closed
5 of 9 tasks
mikalehmann opened this issue Sep 12, 2019 · 4 comments
Closed
5 of 9 tasks

Gutenberg 6.4 breaks FAQ block #13478

mikalehmann opened this issue Sep 12, 2019 · 4 comments
Labels
compatibility component: gutenblocks wait for update Waiting for a third party to reply or fix an issue

Comments

@mikalehmann
Copy link

mikalehmann commented Sep 12, 2019

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

I had to install Gutenberg 6.4 to fix an issue with the editor. Now existing FAQ blocks still work as intended, but as soon as I add a new section, it's not possible to edit the question or the answer.

Please describe what you expected to happen and why.

New sections should be editable as intended.

How can we reproduce this behavior?

  1. Install Gutenberg 6.4 using the official plugin
  2. Create FAQ block
  3. Click on "add question"
  4. Click on the question or answer field
  5. Attempt to write something

Technical info

  • If relevant, which editor is affected (or editors):
  • Classic Editor
  • Gutenberg
  • Classic Editor plugin
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other

Used versions

  • WordPress version: 5.2.3
  • Yoast SEO Premium version: 12.0.1
  • Gutenberg plugin version: 6.4
  • Tested with theme: MagPlus 5.1 & Twenty Nineteen
@Djennez
Copy link
Member

Djennez commented Sep 12, 2019

Hi @lehmax, are you able to reproduce / check this issue on a staging site? If so, can you check if this RC possibly fixes the issue?

@mikalehmann
Copy link
Author

mikalehmann commented Sep 12, 2019

I can also reproduce the issue with 12.1-RC4. Tried it in troubleshoot mode on our staging site. Default theme and only Yoast and Gutenberg were activated. While trying this I also found out that writing into the fields is possible, there is just no cursor and no indicator. You have to click a very specific spot at the end of the default, greyed-out sentence to be able to write. Even if this workaround gives back the ability to write, the buttons to remove the section and add a picture are still not visible.

@Djennez
Copy link
Member

Djennez commented Sep 12, 2019

@lehmax thanks for the tests. The cursor positioning issue was unknown to me. However, it was already known that Gutenberg has introduced some changes that break plugins using custom blocks. An internal issue has already been raised and in this PR we address some styling issues but acknowledging that there are some other issues remaining that need to get investigated on the Gutenberg side.

Though this issue seems to be a duplicate of an issue that we have internally, I will leave this open as a public-facing issue.

@Djennez Djennez added compatibility component: gutenblocks type: bug wait for update Waiting for a third party to reply or fix an issue and removed wait for feedback labels Sep 12, 2019
@dariaknl dariaknl modified the milestone: 12.1 Sep 12, 2019
@Djennez
Copy link
Member

Djennez commented Sep 17, 2019

This problem seems to have been fixed upstream. @lehmax does that fix your issues? There were multiple problems introduced, with the focus as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility component: gutenblocks wait for update Waiting for a third party to reply or fix an issue
Projects
None yet
Development

No branches or pull requests

3 participants