Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 10 support? #82

Closed
dingo-d opened this issue Aug 11, 2022 · 9 comments
Closed

PHPUnit 10 support? #82

dingo-d opened this issue Aug 11, 2022 · 9 comments

Comments

@dingo-d
Copy link

dingo-d commented Aug 11, 2022

Will this package have PHPUnit 10 support?

Seeing how PHPUnit 10 will only work with PHP 8.1 and above, not sure if that would clash with this package. And v10 is a pretty big rewrite from what I gathered.

I tried to test one lib that I'm contributing to on PHP 8.2 and got into dependency issues, where some packages required certain versions of PHPUnit, and I noticed that polyfills support PHPUnit up to v9.

@jrfnl
Copy link
Collaborator

jrfnl commented Aug 11, 2022

@dingo-d 100% the intention. Prelim work for this has already been done and I have a local branch with some additional changes, which is waiting for a PHPUnit 10-RC before I pull it.

The only big challenge I currently see is the changes in/removal of the test listeners and I still need to figure out if the Polyfills can continue to provide a cross-version compatible test listener implementation.

The tests for this package are also already being run against PHPUnit 10 and aside from the testlisteners, there are no incompatibilities at this time.

Note: the above statements are based on the premise of the Polyfills remaining unchanged, i.e. providing a forward-compatible layer. So functionality which is removed from PHPUnit without replacement will not be handled by the PHPUnit Polyfills.

@jrfnl
Copy link
Collaborator

jrfnl commented Aug 24, 2022

I'm closing this issue as until there is a PHPUnit 10-RC release, there is nothing to be done here. All the same, I will pin this issue for visibility as I can imagine other people may have the same question in the near future.

@jrfnl jrfnl closed this as completed Aug 24, 2022
@jrfnl jrfnl pinned this issue Aug 24, 2022
@jrfnl jrfnl added this to the 2.0.0 milestone Nov 16, 2022
@stof
Copy link

stof commented Feb 14, 2023

@jrfnl as PHPUnit 10 is now stable, should this be re-opened ?

@jrfnl
Copy link
Collaborator

jrfnl commented Feb 14, 2023

@stof Good point. I'll be working on this once I'm back from my break. Also see: https://phpc.social/@jrf_nl/109800368057494777

@Stevemoretz
Copy link

Any news on this?

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 9, 2023

@Stevemoretz I've just come back from my break. Working through my email backlog now. Working on this is my next priority after that.

@Stevemoretz
Copy link

@Stevemoretz I've just come back from my break. Working through my email backlog now. Working on this is my next priority after that.

Thanks for the update and the great work!

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 11, 2023

Everyone: I've opened an issue with the roadmap for the PHPUnit Polyfills version to support PHPUnit 10.0.

I'd appreciate it if you could have a read-through and would leave comments if there if there is anything in the roadmap which concerns you.

@jrfnl jrfnl unpinned this issue Mar 11, 2023
@jrfnl
Copy link
Collaborator

jrfnl commented Jun 6, 2023

Closing as version 2.0.0 has been released.

@jrfnl jrfnl closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants