New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues in Geotaichi #17

Open

leyiuu opened this issue Jul 25, 2024 · 1 comment

Assignees

Labels

bug

leyiuu commented Jul 25, 2024

Dear SHI,
Hello,

I've noticed a few issues in the project:

At line 300 in LoadFromFile.py, "GeometryFile" seems incorrect;
In mainDEM, the comment mentions ParticleFile, but LoadFromFile.py uses File at line 122. It would be clearer to make these consistent;
Adding the Destroy boundary condition removes particles outside the domain, causing post-processing issues.

Thank you a lot for your work!
Best regards,
Leyiuu

Owner

Yihao-Shi commented Aug 1, 2024

Hello leyiuu, thanks for your suggestion. We will fix it in the coming version.

Yihao-Shi added the bug label

Yihao-Shi self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment