Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate: encoding crate #1

Open
YamatoSecurity opened this issue Jun 13, 2022 · 2 comments
Open

Investigate: encoding crate #1

YamatoSecurity opened this issue Jun 13, 2022 · 2 comments
Assignees
@hitenkoku
Labels
under-investigation
Milestone
0.7.4

Comments

@YamatoSecurity
Copy link
Contributor

encodingクレートが６年前から更新されていないので、もっと最新のcrateがないか、そもそも別に問題ないか確認した方が良さそうです。
@YamatoSecurity YamatoSecurity added this to the 0.7.4 milestone Jun 13, 2022
@hitenkoku
Copy link
Collaborator

https://github.com/hsivonen/encoding_rs などは同じ目的で利用されていそうです。置き換えられないかどうかは確認してみます

@hitenkoku hitenkoku self-assigned this Sep 16, 2023
@hitenkoku
Copy link
Collaborator

Encodingでのborrow時に利用できるEncodingRefというstructに相当する実装がencoding_rs側にないかつCloneの実装がされていないため、少し修正が大きくなりそうです。

lazy_staticで対応してみて、速度に影響がなさそうか確認してみます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
under-investigation
Projects
None yet
Milestone
0.7.4
Development

No branches or pull requests
2 participants
@hitenkoku @YamatoSecurity