Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelmReleases admission-provider-aws-runtime/application should use admission helm charts #1854

Open
mreichardt95 opened this issue Dec 16, 2024 · 1 comment

Comments

@mreichardt95
Copy link

Flux' HelmReleases like admission-provider-aws-runtime currently use provider-aws Chart when they should be using the admission Chart, like: https://github.com/gardener/gardener-extension-provider-aws/tree/master/charts/gardener-extension-admission-aws/charts

Currently, the admission-provider-aws-application/runtime HelmReleases do not deploy any resources.

apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  annotations:
    meta.helm.sh/release-name: extensions
    meta.helm.sh/release-namespace: flux-system
  name: admission-provider-aws-runtime
  namespace: flux-system
spec:
  chart:
    spec:
      chart: provider-aws
      interval: 1m
      reconcileStrategy: ChartVersion
      sourceRef:
        kind: HelmRepository
        name: gardener-community-charts
        namespace: flux-system
      version: 1.59.1
  dependsOn:
    - name: admission-provider-aws-application 

With https://github.com/gardener/gardener-extension-provider-aws/releases/tag/v1.59.0 the admission part has been seperated into different charts.

@lotharbach
Copy link
Contributor

Fixed with #1935
Will look into Backport releases tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants