Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to control the max sleep time of exponential backoff #149

Open
Xuanwo opened this issue Sep 6, 2024 · 3 comments
Open

feat: Allow to control the max sleep time of exponential backoff #149

Xuanwo opened this issue Sep 6, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Owner

Xuanwo commented Sep 6, 2024

Sometimes user want a max duration for exponential backoff instead of reaching the max times.

@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 11, 2024
@SteveLauC
Copy link
Contributor

SteveLauC commented Sep 12, 2024

Hi, would you like to elaborate on this a bit? What is the difference between this and the ExponentialBuilder.with_max_delay(max_dur) API?

@Xuanwo
Copy link
Owner Author

Xuanwo commented Sep 12, 2024

ExponentialBuilder.with_max_delay(max_dur)

The max_delay is the delay for each sleep, but this feature requires a total_delay so users can ensure that the retry won't exceed the total_delay.

@SteveLauC
Copy link
Contributor

Get it, let me take a look at this:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants