Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more automated tests #847

Closed
totaam opened this issue Apr 29, 2015 · 17 comments
Closed

more automated tests #847

totaam opened this issue Apr 29, 2015 · 17 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Apr 29, 2015

Issue migrated from trac ticket # 847

component: tests | priority: critical | resolution: fixed

2015-04-29 08:27:08: antoine created the issue


Follow up from #177, see also #660 - in particular things like #822.

  • integration tests: we want some tests that start a server and connect to it.
    Shadow server, normal server, proxy, etc... Even the tcp proxy can be exercised this way.
    Concurrent connections (spawn 10 xpra info?), etc.

Here's a tricky one that I would like to be able to catch with some tests, but it is going to be HARD: r8604 broke nvenc4 + nvenc5 with the proxy server only (fixed by r9413 + backport in 9414).

  • client rendering tests: we should be able to fire up a virtual display, create a window (try both pixmap and opengl backends) and paint on it (no client class involved), then check that no errors or exceptions were triggered.

  • this one would be hard to check for: xpra start fails on OS X #867

@totaam
Copy link
Collaborator Author

totaam commented Apr 29, 2015

2015-04-29 10:29:46: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Apr 29, 2015

2015-04-29 10:29:46: antoine commented


(fix milestone - too late for 0.15)

@totaam
Copy link
Collaborator Author

totaam commented May 18, 2015

2015-05-18 08:35:20: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented May 20, 2015

2015-05-20 04:11:42: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented May 20, 2015

2015-05-20 04:11:42: antoine changed title from add some client-server integration tests to more automated tests

@totaam
Copy link
Collaborator Author

totaam commented May 21, 2015

2015-05-21 12:58:10: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Jul 28, 2015

2015-07-28 07:54:27: antoine commented


I don't see how this can easily be automated, but it would be nice to catch bugs like #926 automatically.

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 08:30:51: antoine changed priority from major to critical

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 08:30:51: antoine commented


And also catch things like: #1031

@totaam
Copy link
Collaborator Author

totaam commented Jul 12, 2016

2016-07-12 17:51:51: antoine commented


Milestone renamed

@totaam
Copy link
Collaborator Author

totaam commented Aug 21, 2016

2016-08-21 10:55:50: antoine commented


Milestone renamed

@totaam
Copy link
Collaborator Author

totaam commented Jan 28, 2017

2017-01-28 10:09:50: antoine changed status from assigned to new

@totaam
Copy link
Collaborator Author

totaam commented Jan 28, 2017

2017-01-28 10:09:50: antoine changed owner from antoine to smo

@totaam
Copy link
Collaborator Author

totaam commented Jan 28, 2017

2017-01-28 10:09:50: antoine commented


As of r14869 + r14868 + r14867 + r14866, the unit tests have been improved, most run with both python2 and python3 and we now also run the tests as part of the build process for win32 (r14870) and osx (r14871)!

@smo: FYI, feel free to just close.

@totaam
Copy link
Collaborator Author

totaam commented Feb 6, 2017

2017-02-06 23:34:34: smo changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Feb 6, 2017

2017-02-06 23:34:34: smo set resolution to fixed

@totaam totaam closed this as completed Feb 6, 2017
@totaam
Copy link
Collaborator Author

totaam commented Sep 8, 2017

2017-09-08 10:37:11: antoine commented


For reference, the latest run scripts allow us to pass a specific unit test to run (useful for debugging), and the following environment variables are also useful:

DELETE_TEMP_FILES=0 \
XPRA_ALL_DEBUG=1 \
XPRA_TEST_DEBUG=1 \
    ./run2 ./unit/server/server_sockets_test.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant