Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows lost images #809

Closed
totaam opened this issue Feb 14, 2015 · 71 comments
Closed

windows lost images #809

totaam opened this issue Feb 14, 2015 · 71 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 14, 2015

Issue migrated from trac ticket # 809

component: client | priority: major | resolution: invalid

2015-02-14 03:18:31: John1221 created the issue


Server: Ubuntu 14.04 amd64, xpra version 0.15.0 13-Feb-2015 08:00
Client: MS Windows 7 32bit, xpra version 0.15.0 r8661

  • Open Firefox
  • Minimize and restore instantly
  • Firefox losts all images
@totaam
Copy link
Collaborator Author

totaam commented Feb 14, 2015

2015-02-14 03:19:27: John1221 uploaded file lost_image.png (15.7 KiB)

lost_image.png

@totaam
Copy link
Collaborator Author

totaam commented Feb 14, 2015

2015-02-14 03:20:28: John1221 commented


I forgot this: Maximize Firefox first, then minimize...

@totaam
Copy link
Collaborator Author

totaam commented Feb 16, 2015

2015-02-16 07:17:00: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Feb 16, 2015

2015-02-16 07:17:00: antoine commented


Once again, I can't reproduce this one.
Can you please post "xpra info" when this happens?
Does it help if you select "raise windows" from the tray?
Does it help if you toggle opengl on or off from the tray?

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 06:53:39: John1221 uploaded file lost_image_log_150224.txt (87.6 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 07:02:17: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 07:02:17: John1221 commented


Once again, I can't reproduce this one.
[[BR]]
I will reproduce again, maybe this helps:

  • Open Firefox
  • Make sure that Firefox are maximize.
  • Minimize and restore instantly from taskbar (double click to Firefox button).
  • Firefox losts all images (likes the first screenshot).
    [[BR]]

Can you please post "xpra info" when this happens?
[[BR]]
xpra info: [/attachment/ticket/809/lost_image_log_150224.txt]
[[BR]]

Does it help if you select "raise windows" from the tray?
[[BR]]
No.
[[BR]]

Does it help if you toggle opengl on or off from the tray?
[[BR]]
Both server and client don't support opengl.

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 09:18:21: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 09:18:21: antoine commented


John1221: nothing there looks suspicious :(
I'll have to test with the exact same versions and OS..

Until then, does it make any difference if you use a different encoding? (ie: rgb)

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 09:36:53: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 09:36:53: John1221 commented


antoine: don't have any difference if I use others encoding ( png, rgb, jpeg,...)
After lost image, If I make the Firefox from maximize to normal state ( press restore button ), then the window images return to normal.

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 09:41:04: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2015

2015-02-24 09:41:04: antoine commented


OK, thanks.

The fact that this also affecting firefox, and also related to maximized state makes me think that this could be the same bug as #790: maybe the application thinks it isn't mapped when it is, so the contents are empty.

@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2015

2015-02-25 02:22:00: John1221 commented


Update: don't need to minimize and restore INSTANTLY, just need to minimize and then, restore a window.

@totaam
Copy link
Collaborator Author

totaam commented Mar 21, 2015

2015-03-21 17:45:09: antoine changed status from assigned to new

@totaam
Copy link
Collaborator Author

totaam commented Mar 21, 2015

2015-03-21 17:45:09: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Mar 21, 2015

2015-03-21 17:45:09: antoine commented


Is this fixed as per #790?

@totaam
Copy link
Collaborator Author

totaam commented Mar 24, 2015

2015-03-24 03:48:33: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Mar 24, 2015

2015-03-24 03:48:33: John1221 commented


@antoine: Tested with Firefox and xterm with server ( trusty, xpra 0.15 r8802), client( MS Windows 7, xpra 0.15 r8826)
Firefox is fixed, but xterm still occurs ( lost all text in xterm)

@totaam
Copy link
Collaborator Author

totaam commented Mar 24, 2015

2015-03-24 04:48:17: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Mar 24, 2015

2015-03-24 04:48:17: antoine commented


Great for Firefox.
In a way, that's good, because xterm if far is easier to debug and test.

Sorry to ask again but can you give me exact steps to reproduce with just an xterm? (as simple as you can make them)

And if the bug is to do with maximize, please add to #790 instead of this one.

@totaam
Copy link
Collaborator Author

totaam commented Mar 24, 2015

2015-03-24 05:09:51: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Mar 24, 2015

2015-03-24 05:09:51: John1221 commented


@antoine:
Reproduce:

  1. Server-side: xpra start :100 --start-child=xterm --bind-tcp=0.0.0.0:1000 --no-cursors --no-pulseaudio --no-speaker
  2. Client-side:
  • Attach xpra : Xpra_cmd.exe attach tcp:IPADDRESS:1000
  • Open xterm, don't need maximize
  • Minimize xterm, and then restore, don't need do quickly
    Now xterm lost all text. Then if I maximize it -> all text appear.

Hope this helps :)

@totaam
Copy link
Collaborator Author

totaam commented Apr 15, 2015

2015-04-15 09:44:05: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Apr 15, 2015

2015-04-15 09:44:05: antoine commented


Sorry for taking so long to test this very obvious bug.
The reproduction steps were very easy.

This is fixed in r9009. I think this was caused by the work in #775.
We now synchronize the "iconified" flag too when we detect a change, and not just when the window gets unmapped (hopefully this won't cause regressions).

Feel free to test the latest server builds (the client is unchanged) and report back.

@totaam
Copy link
Collaborator Author

totaam commented Apr 16, 2015

2015-04-16 02:41:32: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Apr 16, 2015

2015-04-16 02:41:32: John1221 commented


I couldn't find the beta build r9009.
So I tested the latest server(TRUSTY) builds on 10 April, 2015(http://xpra.org/beta/trusty/main/binary-amd64/xpra_0.15.0-1_amd64.deb), the latest client(WINDOWS) builds (r8987) at the same time.
Xterm still occurs this bug.

@totaam
Copy link
Collaborator Author

totaam commented Apr 16, 2015

2015-04-16 04:29:22: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Apr 16, 2015

2015-04-16 04:29:22: antoine commented


@john1221: the fix is in r9009, so r8987 is too old. I have just posted some newer builds (trusty only).

@totaam
Copy link
Collaborator Author

totaam commented Apr 16, 2015

2015-04-16 07:44:56: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Nov 16, 2015

2015-11-16 02:21:21: John1221 changed status from closed to reopened

@totaam
Copy link
Collaborator Author

totaam commented Nov 16, 2015

2015-11-16 02:21:21: John1221 removed resolution (was fixed)

@totaam
Copy link
Collaborator Author

totaam commented Nov 16, 2015

2015-11-16 02:21:21: John1221 commented


I've upgraded xpra server to 0.15.8-3, xpra client to 0.16.0-r11206.
This bug can reproduce like comment:17
I can also reproduce with xpra client version 0.16.0 r10853 and 0.16.0 r11176. Haven't test with some versions between r10853 and r11176 yet.

@totaam
Copy link
Collaborator Author

totaam commented Nov 18, 2015

2015-11-18 12:38:38: antoine changed status from reopened to new

@totaam
Copy link
Collaborator Author

totaam commented Nov 18, 2015

2015-11-18 12:38:38: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Nov 18, 2015

2015-11-18 12:38:38: antoine commented


Interesting: I tested with 0.16 latest and could not reproduce this particular problem at all (even though I did see it last time in comment:20).
I have tested with many servers:

  • Fedora 23 (both latest trunk and latest 0.15.x)
  • Ubuntu 14.04
    with Firefox 42, XP client.

I did see something fishy going on with the window style: the print dialog does not have a minimize or maximize option when it first shows up but as soon as the fixup_window_style() hook runs, it does. This is fixed in r11284.
You can still use the taskbar to minimize things and try to trigger this bug.

@john1221: can you reproduce this bug with the latest win32 beta?

@totaam
Copy link
Collaborator Author

totaam commented Nov 21, 2015

2015-11-21 02:16:01: John1221 commented


I also tested with server(Ubuntu 14.04) and Firefox 42, but Windows 7 64bit client

It still appear with the latest r11304 win32 beta

@totaam
Copy link
Collaborator Author

totaam commented Nov 21, 2015

2015-11-21 02:16:26: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Nov 21, 2015

2015-11-21 12:46:47: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Nov 21, 2015

2015-11-21 12:46:47: antoine commented


I have now tested again with:

  • Ubuntu 14.04 server running 0.15.8 standard package
  • Windows 7 Ultimate client with r11304 client

Still cannot reproduce.
I cannot follow the instructions from comment:17 exactly, as the minimize button is now missing from the print dialog.
I have tried using the taskbar and using the main window to minimize all firefox windows.

@john1221: can you give me more specific steps?
Can you try a few more things to narrow it down? (opengl on/off, other applications? etc..)

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 02:09:18: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 02:09:18: John1221 commented


I'm sorry. Has a mistake at here "Press minimize button from the Print dialog", it should be "Press Firefox windows button from the taskbar to minimize all Firefox windows". Maybe the Print dialog has a minimize button, but from previous version of Firefox.

I tried narrowing opengl off, and images were still good. I think my problem is opengl. From "Session Info", I can see the server doesn't support (or not yet) opengl(n/a) but the client does.

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 03:28:27: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 03:28:27: antoine commented


Maybe the Print dialog has a minimize button, but from previous version of Firefox.
[[BR]]
As per comment:23, this was a bug in xpra - now fixed.

[[BR]]

I think my problem is opengl. From "Session Info", I can see the server doesn't support (or not yet) opengl(n/a) but the client does.
[[BR]]
No, this is unrelated: the server never shows its opengl information.

I can reproduce this bug with 0.15.x clients, but not with any recent 0.16.x clients.
So unless you can give me accurate and reliable steps to reproduce this bug, I will have to close this as "worksforme".

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 07:28:39: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 07:28:39: John1221 commented


Prepare:

  • Server command: xpra start :100 --start-child=firefox --bind-tcp=0.0.0.0:10000
  • Client command: <path-to-xpra-client>\Xpra-0.16.0-[r11304](../commit/f8e7a44d1376ef8809a11fa36f87eb1809147ca8)\Xpra_cmd.exe attach tcp:IP:10000 --opengl=yes
    Reproduce:
  • After Firefox was appeared, press Ctrl + P to open Print dialog (or Ctrl + O to open Open Files dialog)
  • We can call this state is (A).
  • Press Firefox button from the taskbar to minimize all Firefox windows (main window and Print dialog).
  • Press Firefox button again to restore all Firefox windows state to (A)
  • Print dialog lost all images.

You can also watch this video.

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 07:32:23: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 07:32:23: antoine commented


Watched the video and this is exactly what I am doing when testing.
The only difference being that I don't have opengl enabled in the win32 client. (because it is running in a virtual machine)
I see that you are forcing it on, why?
Have you tried disabling opengl in the client? Either from the command line or after connecting from the systray?

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 08:18:26: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 08:18:26: John1221 commented


I tried disabling opengl in the client, as I said in comment:27, from the command line and this bug don't appear again.
Btw, I think if I force opengl on, the client will be using GPU and improve Xpra's performance.

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 08:37:49: antoine changed owner from antoine to John1221

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 08:37:49: antoine commented


I tried disabling opengl in the client, as I said in comment:27, from the command line and this bug don't appear again.
[[BR]]
Ah, I didn't understand this:
[[BR]]
I tried narrowing opengl off, and images were still good
[[BR]]

Please post your ClientRendering OpenGL debugging information (the gl_check tool output from the client).
Is opengl enabled or disabled by default on your system? Is this why you force it on?

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 09:10:20: John1221 changed owner from John1221 to antoine

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 09:10:20: John1221 commented


OpenGL debugging information from the client:

OpenGL_accelerate module loaded


OpenGL properties:
* GLU extensions           : GL_EXT_bgra
* GLU version              : 1.2.2.0 Microsoft Corporation
* accelerate               : 3.1.0
* display_mode             : DOUBLE
* gdkgl.version            : 6.1
* gdkglext.version         : 1.2.0
* gtkglext.version         : 1.2.0
* has_alpha                : True
* max-viewport-dims        : (16384, 16384)
* opengl                   : 4.2
* pygdkglext.version       : 1.0.0
* pyopengl                 : 3.1.0
* renderer                 : Intel(R) HD Graphics 4600
* rgba                     : True
* safe                     : True
* shading language version : 4.20 - Build 10.18.10.3412
* texture-size-limit       : 16384
* transparency             : False
* vendor                   : Intel
* zerocopy                 : True

Is opengl enabled or disabled by default on your system?
\Opengl is enabled by default.
\
Is this why you force it on?
\Yes, as I said.I think if I force opengl on, the client will be using GPU and improve Xpra's performance. It's right, or I misunderstand something?
\

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 09:14:00: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 09:14:00: antoine set resolution to invalid

@totaam
Copy link
Collaborator Author

totaam commented Nov 23, 2015

2015-11-23 09:14:00: antoine commented


If you force something on, please mention it early.
ReportingBugs clearly states that you should include the command lines for example and also clearly states: changes made to the default configuration, if any.

Had I known that you were forcing opengl on from the start, this bug would have taken minutes to close rather than the 9 months it has now taken.

Closing as invalid: we disable opengl on intel chipsets because the drivers are not reliable. Anyone second guessing the software and forcing this on should be prepared to deal with the fallout, such as this one.

@totaam totaam closed this as completed Nov 23, 2015
@totaam
Copy link
Collaborator Author

totaam commented Dec 16, 2015

2015-12-16 03:38:55: antoine commented


See ClientRendering OpenGL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant