Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please show connection endpoint in tooltip #479

Closed
totaam opened this issue Dec 18, 2013 · 6 comments
Closed

please show connection endpoint in tooltip #479

totaam opened this issue Dec 18, 2013 · 6 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 18, 2013

Issue migrated from trac ticket # 479

component: core | priority: major | resolution: fixed

2013-12-18 17:01:42: onlyjob created the issue


In earlier versions of Xpra there used to be an immensely useful feature to show connection endpoint in tooltip (see r1555, r1557, r1558) which is very convenient when more than one session attached.

In xpra-0.10.9 I've noticed that tooltip show only "Xpra" so I can't distinguish between xpra sessions. Please show connection endpoint in tooltip in order to help find which 'X' icon in system tray controls the desired session (when multiple sessions attached).

I don't remember when this regression appeared again... Thanks.

@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2013

2013-12-19 00:29:52: totaam changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2013

2013-12-19 00:29:52: totaam changed owner from antoine to totaam

@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2013

2013-12-19 00:29:52: totaam commented


Ah, the tray code got refactored in 0.10.x, so some platforms (osx/win32 and hopefully soon also *nix) no longer use the gtk.StatusIcon which is a little bit too limited for our needs: it doesn't let us get an event when the mouse hovers over the icon and pass it to the server, we can only set the tooltip. The code must have fallen through that. Will fix.

@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2013

2013-12-19 15:31:59: totaam changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2013

2013-12-19 15:31:59: totaam changed resolution from ** to fixed

@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2013

2013-12-19 15:31:59: totaam commented


r5007 + r5008 restores the code which uses the connection endpoint as title.

backported to v0.10.x in 5009 (only the first one is needed there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant