Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle 16 and 30-bit pixels in cairo backend #2839

Closed
totaam opened this issue Jul 11, 2020 · 5 comments
Closed

handle 16 and 30-bit pixels in cairo backend #2839

totaam opened this issue Jul 11, 2020 · 5 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 11, 2020

Issue migrated from trac ticket # 2839

component: client | priority: major | resolution: fixed

2020-07-11 13:53:51: antoine created the issue


Similar to #2828 but for the non-opengl case.

@totaam
Copy link
Collaborator Author

totaam commented Jul 11, 2020

2020-07-11 13:58:22: antoine commented


Done in r26951 for plain "r210" (aka RGB30).

Still TODO:

  • actually test on 30-bit displays and verify that the extra 2 bits of pixel depth are used
  • convert GBRP10 to [r210](../commit/8875e19d8d67a1e2eeb8f189c9b1d526bd1d0e44) via csc_cython so that we can use h264
  • maybe also add FORMAT_RGB16_565?

@totaam
Copy link
Collaborator Author

totaam commented Jul 11, 2020

2020-07-11 17:14:57: antoine uploaded file csc_cython-GBRP10_to_r210.patch (7.0 KiB)

adds GBRP10_to_r210 to csc_cython

@totaam
Copy link
Collaborator Author

totaam commented Jul 11, 2020

2020-07-11 17:15:42: antoine commented


The resulting picture is only half the height!? (reading more segfaults)
Is it the decoder or the csc that is wrong?

@totaam
Copy link
Collaborator Author

totaam commented Jul 11, 2020

2020-07-11 17:50:01: antoine commented


r26956 + r26957 adds support for 16-bit BGR565 pixels (aka cairo.FORMAT_RGB16_565)

@totaam
Copy link
Collaborator Author

totaam commented Jul 12, 2020

2020-07-12 15:24:04: antoine commented


r26960 does the conversion from GBRP10 to [r210](../commit/8875e19d8d67a1e2eeb8f189c9b1d526bd1d0e44) which allows us to handle 10-bit video in both opengl and non-opengl cases.

All looks good, except on win32 (headerbar bug): #2539#comment:20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant