Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell clients that the video has ended #1850

Closed
totaam opened this issue May 21, 2018 · 3 comments
Closed

tell clients that the video has ended #1850

totaam opened this issue May 21, 2018 · 3 comments

Comments

@totaam
Copy link
Collaborator

totaam commented May 21, 2018

At the moment, we keep the decoder context alive until we either discard the window or create a new one, we should be telling the client when it can be discarded.
In some cases, we may already have sent an EOS packet, but what this does is free some of the decoder's internal state, not the decoder itself.

(slightly related to #1836)

@totaam
Copy link
Collaborator Author

totaam commented May 21, 2018

  • implemented in r19360
  • html5 client support (+python fixup) added in r19361.

Still TODO: add timer to automatically recycle video contexts when window updates stop

@totaam
Copy link
Collaborator Author

totaam commented May 22, 2018

We now timeout the video encoder context after XPRA_VIDEO_TIMEOUT seconds (defaults to 10): r19364 + r19365.

(it's a little bit wasteful to keep re-scheduling this timer for every frame we process but doing anything more clever would increase code complexity)

@totaam totaam closed this as completed May 22, 2018
@totaam
Copy link
Collaborator Author

totaam commented Jun 9, 2018

Caused a regression: #1868.

Testing note: the effect of the EOS timer can be seen with:

xpra info | grep -e "window\.[0-9]*\.encoder="

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant