Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixins cleanups #1778

Closed
totaam opened this issue Mar 1, 2018 · 3 comments
Closed

mixins cleanups #1778

totaam opened this issue Mar 1, 2018 · 3 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 1, 2018

Follow up from #1761 + #1700.

Tasks:

  • keyboard, ie: modifier_client_keycodes is still too ugly
  • hello packet code
  • init_ui
  • r18656 for window server: remove all window packet handlers if window forwarding is disabled
  • networkstate: pings require statistics object - move it out into its own domain?
  • ServerCore.setup(): we init_auth and init_html_proxy with options, should be split into a parsing step + setup step (means losing support for the legacy password-file - and need another solution for socket_dir in sys-auth-base)
  • more consistent namespace for mixin variables, try to distinguish: settings (command line, env vars), server settings (from hello or update packets), state (focus, buttons, etc)
  • some timers can now be tracked and cancelled more easily (ie: ping timers)
@totaam
Copy link
Collaborator Author

totaam commented Jun 26, 2019

server mixins: #1838

client mixins: #1861

@totaam
Copy link
Collaborator Author

totaam commented Jul 22, 2019

Things are in pretty good shape already, see links in comment:2.
See also #2362.

The main dependency issues can be clearly seen by looking at the test code:

  • we inject a fake _protocol attribute
  • we inject a fake _server_sources dictionary
  • some other minor attributes (ie: _upgrading flag, session_name, machine_id, etc..) - some could be duplicated, others

@totaam
Copy link
Collaborator Author

totaam commented Feb 6, 2020

This will do for now, follow up in #2578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant