uinput device permissions

[totaam]

Issue migrated from trac ticket # 1631

component: server | priority: major | resolution: fixed

2017-09-02 11:40:45: antoine created the issue

---

Follow up from #1611.

We want to be able to continue to use uinput when upgrading a server.

The patch attached almost kinda works, with some problems:

• requires "xprop" to find the device uuid... ugly
• the part of the patch that uses the device name to match the device cannot be used, as udev doesn't understand regex in the ATTRS match section... so we'll need to use something else (the device part of the USBID?)
• we chmod the device to 0666 initially so that the existing X11 server can add the new device, that's dangerous - we need to chmod / chown it to the user the server belongs to

[totaam]

2017-09-02 11:41:03: antoine uploaded file uinput-upgrades.patch (15.8 KiB)

work in progress patch

[totaam]

2017-09-02 18:36:30: antoine changed status from new to closed

[totaam]

2017-09-02 18:36:30: antoine set resolution to fixed

[totaam]

2017-09-02 18:36:30: antoine edited the issue description

[totaam]

2017-09-02 18:36:30: antoine commented

---

Done in r16777:

• we hijack the "version" attribute of the uinput device to pass the uid to our custom udev program which tells udev which "OWNER" value to use for the new device. That way, the permissions are correct as soon as the device is created.
• we also append a random string to the device name to ensure that the same user can run multiple sessions: each device will only be used by the server that knows its full name. We save the name as a root X11 property so we can re-create a new device when doing a server upgrade (or with --use-display).