Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix painting cursor with opengl #1497

Closed
totaam opened this issue Apr 12, 2017 · 4 comments
Closed

fix painting cursor with opengl #1497

totaam opened this issue Apr 12, 2017 · 4 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Apr 12, 2017

Follow up from #1496, see r15576.

We copy the pixels one at a time which is horrid.
Someone who understands opengl should fix the texture code instead..

@totaam
Copy link
Collaborator Author

totaam commented Jul 22, 2019

For reference, the current (broken) code can be enabled using:

XPRA_OPENGL_TEXTURE_CURSOR=1 xpra attach ...

And the actual painting code can be seen by looking for TEXTURE_CURSOR in /browser/xpra/trunk/src/xpra/client/gl/gl_window_backing_base.py.

@totaam
Copy link
Collaborator Author

totaam commented Jul 22, 2019

Well, I'll be damned!

Following the precious advice that glEnablei(GL_BLEND) was invalid, I removed it in r23265. (after wrongly trying to replace it by glEnable(GL_BLEND) in r23263, which quickly got reverted in r23264 as painting was broken)

r23266 + r23267 does replace it though, but only for the cursor paint code, and now it seems to work!
So r23269 enables it by default.

I am keeping this ticket open, because this is going to need a lot more testing.
Already tested:

  • win32 shadow server
  • seamless X11 transparent windows

@totaam
Copy link
Collaborator Author

totaam commented Jul 22, 2019

r23270 also disables GL_BLEND once we're done painting the cursor

@totaam
Copy link
Collaborator Author

totaam commented Aug 1, 2019

Works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant