Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to exit start-desktop server with xpra stop #1371

Closed
totaam opened this issue Nov 23, 2016 · 5 comments
Closed

Unable to exit start-desktop server with xpra stop #1371

totaam opened this issue Nov 23, 2016 · 5 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 23, 2016

Issue migrated from trac ticket # 1371

component: server | priority: major | resolution: fixed

2016-11-23 20:09:20: maxmylyn created the issue


We aren't handling start-desktop desktop servers (need better terminology for this - I vote "virtual desktop") properly with regards to exiting. Running xpra stop :DISPLAY on a virtual desktop server fails to do anything - nothing in the server logs indicate it gets a connection at all, and the terminal will hang for a few seconds until it times out, then exits.

I am able to exit the server with a SIG-INT if I run with --no-daemon.

The server I am running on is a Fedora 24 trunk r14479 server, and the client is a Fedora 24 trunk r14479 client. I was also doing some testing on a Windows 8.1 client, but the issue is server side.


Other than that, the virtual desktop (or whatever we choose to call it) functionality works quite nicely, and I can see quite a few useful use cases.


Not sure what log flags you want, but let me know and I'll get them to you.

@totaam
Copy link
Collaborator Author

totaam commented Nov 24, 2016

2016-11-24 07:30:33: antoine changed owner from antoine to maxmylyn

@totaam
Copy link
Collaborator Author

totaam commented Nov 24, 2016

2016-11-24 07:30:33: antoine commented


need better terminology for this - I vote "virtual desktop")
[[BR]]
I disagree, this is a "start" command, adding "virtual" doesn't really clarify anything as all the "start" commands are using virtual displays (windows or desktops).
Remember that the xpra subcommands are verbs not nouns. ie: "list", "attach", etc..
ie: especially when running a remote command like xpra virtual-desktop ssh:SOMEHOST, this would not be as clear as saying "start-desktop" (or "attach").


I cannot reproduce:

$ xpra start-desktop :100 --start=xterm
Entering daemon mode; any further errors will be reported to:
  /run/user/1000/xpra/:100.log
$ xpra list
Found the following xpra sessions:
/run/user/1000/xpra:
	LIVE session at :100
(..)
$ xpra stop :100
server requested disconnect: server shutdown
xpra at :100 has exited.

Using just xpra stop also works if you only have one session running.

Tested on Fedora 23, 24 and 25. No problem on any of them.
Maybe your installation is broken? Try cleaning everything before reinstalling.

If that does not help, please provide more detailed steps with the "-d all" debug logs, as well as the full package list and python package file lists.

For reference, the original tickets are here: #1247 #1206

@totaam
Copy link
Collaborator Author

totaam commented Nov 28, 2016

2016-11-28 17:19:00: maxmylyn changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Nov 28, 2016

2016-11-28 17:19:00: maxmylyn set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Nov 28, 2016

2016-11-28 17:19:00: maxmylyn commented


Did a thorough turfing and rebuild from latest r14493 source - that seemed to fix it. Must've been a one-time thing. Closing.

@totaam totaam closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant