Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize client colourspace / calibration #1155

Open
totaam opened this issue Mar 30, 2016 · 7 comments
Open

synchronize client colourspace / calibration #1155

totaam opened this issue Mar 30, 2016 · 7 comments
Milestone

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 30, 2016

We want to capture the colour profile that the client will use for rendering our pixels on screen(s) and expose it to the server so applications will use it, and / or ensure we use this profile when encoding the pixels.

Links:


MS Windows specific info:


OSX:


As per the arch wiki, a number of apps already use the icc profile: firefox, eog, gimp, mpv, ..

Here's how I set my icc profile:

xcalib ~/.Seiki_pro_SM40UNP_user.icm
@totaam
Copy link
Collaborator Author

totaam commented Mar 30, 2016

  • r12282 + r12292 adds basic ICC information for win32 collected using pillow which calls GetICMProfile - we could pass it an HDC for each monitor to get per-monitor information, but this would need to go with changes to ensure that the monitor indexes used for reporting the geometry are the ones used for icc (GTK messes with things and may re-order monitors...)
  • r12284 does the same for OSX, where we get per-monitor values too (same monitor-order caveat applies) - here, we do get the raw ICC data in a blob already, so this can easily be applied server-side
  • for Linux, I think we need to make sure python-pillow is built with lcms support - and even then, I don't get any values out.. but I do get lots of data using colormgr get-devices

@totaam
Copy link
Collaborator Author

totaam commented Jun 16, 2016

For printing colour accuracy, see: Ghostscript Color Management.

@totaam
Copy link
Collaborator Author

totaam commented Jun 22, 2016

opengl: fbo colorspace and ARB_framebuffer_sRGB.

@totaam
Copy link
Collaborator Author

totaam commented Aug 10, 2016

Time to collect some data, at least on OSX and win32.

Then we can decide what to do with it.

Lots of work done on this: OSX clients colourspace detection, ICC profile export to the session - #1086

@totaam
Copy link
Collaborator Author

totaam commented Aug 10, 2017

I don't have the hardware required for testing this, re-scheduling.

Some good links:

@totaam
Copy link
Collaborator Author

totaam commented Feb 24, 2018

I'm not alone in thinking that colour management on Linux is a mess: Open Source Color Management is broken

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2019

See also #1584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant