This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk_load): add bulk load max rollback count #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
added
component/bulk-load
type/config-change
levy5307
reviewed
Apr 28, 2021
levy5307
previously approved these changes
Apr 29, 2021
|
LGTM |
neverchanje
reviewed
Apr 29, 2021
neverchanje
reviewed
Apr 29, 2021
hycdong
changed the title
…to bulk_load_rollback_count
foreverneverer
approved these changes
May 6, 2021
levy5307
approved these changes
May 6, 2021
hycdong
added a commit
that referenced
this pull request
May 7, 2021
hycdong
added a commit
that referenced
this pull request
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During bulk load process, meta server will control the bulk load status switch: downloading -> downloaded -> ingesting -> succeed, if replica configuration changed or network failed, meta server will rollback status into downloading. In pervious implementation, it is possible for bulk load process rollback for long time. This pull request adds
bulk_load_max_rollback_times, if the table has been rollback to downloading for too many times, it will turn status into failed to stop the process.configuration update:
[meta_server] +bulk_load_max_rollback_times = 10