This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix: do not call unregister_rpc_handler when exiting progress #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exiting progress
dsn::task::get_current_node()
isnullptr
, so we shouldn't calldsn_rpc_unregiser_handler
. Also, when therpc_engine
destructed, all handlers have been cleared, this is no need to calldsn_rpc_unregiser_handler
.