This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(split): small refactor and fix of replica split #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
changed the title
neverchanje
reviewed
Oct 12, 2020
Comment on lines
788
to
793
| if (status() != partition_status::PS_PARTITION_SPLIT) { | ||
| dwarn_replica("child partition has been active, status={}", enum_to_string(status())); | ||
| return; | ||
| } | ||
|
|
||
| ddebug_replica("child partition become active"); |
There was a problem hiding this comment.
if (status() != partition_status::PS_PARTITION_SPLIT) {
dwarn_replica("child partition has been active, status={}", enum_to_string(status()));
return;
}
ddebug_replica("child partition become active");
The two logs seem ambiguous. They both say the partition is "active". I think you should add a comment here, stating what it means "active". And I guess the latter log should be "is becoming active".
There was a problem hiding this comment.
Yes, I move the latter log after child status changed, it will be clearer.
neverchanje
reviewed
Oct 12, 2020
neverchanje
reviewed
Oct 12, 2020
acelyc111
approved these changes
Oct 12, 2020
foreverneverer
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about
replica_split_manager, including: