This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(security): use blob instead of std::string as the type for msg member of negotiationi_request #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
approved these changes
Sep 10, 2020
neverchanje
approved these changes
Sep 10, 2020
levy5307
added a commit
to levy5307/rdsn
that referenced
this pull request
Dec 21, 2020
…sg member of negotiation_request (XiaoMi#622)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we use
std::stringas the type for msg member ofnegotiation_requestandnegotiation_response.But as we known,
std::stringin cpp is not binary safe, so if we pass some special character(like '\0'), this string will be incorrect.And in negotiation process, auth token transfered between
server_negotiationandclient_negotiationmay have these special characters mentioned above.So in this pull request, I change to use
blobinstead ofstd::string