build: use nodejs/http_parser as a external dep #591
Conversation
neverchanje
force-pushed
the
http-refactoring-parser-cmake
branch
from
24494ed to
dd201b6
Compare
| URL_MD5 f6900b9209d3d6b80c70e050ac33b834 | ||
| CONFIGURE_COMMAND mkdir -p ${TP_OUTPUT}/include/nodejs | ||
| BUILD_COMMAND "" | ||
| INSTALL_COMMAND cp -R http_parser.h ${TP_OUTPUT}/include/nodejs/http_parser.h |
There was a problem hiding this comment.
This thirdparty is only copied to output directory but compiled in rdsn project?
There was a problem hiding this comment.
Yes. We don't compile http_parser as "libhttp_parser.a", otherwise we must link this library to every place. This PR only modifies where the source is placed, from our git to 3rdparties.
There was a problem hiding this comment.
Only http related modules need link this library, I think keep logic clear and unified would be better.
There was a problem hiding this comment.
"Only http related modules need link this library"
Yes, which means meta-server, replica-server, and all related modules need to link this library. It's not trivial.
If we don't make it an external dependency, I will paste the http-parser v2.9.4 sources to replace the current.
No description provided.