This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(security): init kerberos #585
feat(security): init kerberos #585
Changes from 26 commits
0b99fdb
371453d
8e2e392
6e8b03c
0f46110
fb99365
dbae3e1
9625159
48f9d0e
8c240c7
bbd0f28
102f8e9
dd6a2ae
fa1285c
66c44d8
3052fd9
bbcb249
2d70d13
6a3b1af
bc898b4
7c6d38d
1b1f12d
da94b16
5767e5e
a41bbe8
b4fa990
ac54c07
e6c7f75
d18f370
ce71a2a
ea0f5bf
8d584da
f4f1d5d
ee19b83
c55ab09
6e60cc3
5b96be6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So don't forget to update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which docs do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://pegasus.apache.org/overview/compilation & https://github.com/XiaoMi/pegasus/blob/master/docs/installation.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to split the function into two functions. Because they are almost same