This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(cold-backup): add rate limit for fds #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
April 20, 2020 15:44
levy5307
changed the title
levy5307
changed the title
|
I think we should separte this PR into at least 2 PRs, one to add a new thirdparty lib, and the other to use this lib for coldbackup. |
acelyc111
previously approved these changes
Apr 30, 2020
neverchanje
reviewed
Apr 30, 2020
neverchanje
reviewed
Apr 30, 2020
| "rocksdb_write_buffer_size", | ||
| 64 * 1024 * 1024, | ||
| "rocksdb options.write_buffer_size"); | ||
| uint64_t max_sst_file_size = std::max(target_file_size, (uint64_t)1.25 * write_buffer_size); |
There was a problem hiding this comment.
rDSN & FDS client should not assume anything about Pegasus, as well as the details around rocksdb. Pegasus is the submodule aka one of the storage engines of rDSN. What if we use other storage engines without rocksdb_write_buffer_size?
There was a problem hiding this comment.
But we should get the file size, or we must set the burst size to a very big number.
Do you have another better way?
There was a problem hiding this comment.
Yes, it's bit of tricky here, but in the following plan, we are going to merge rdsn and pegasus projects.
hycdong
reviewed
Apr 30, 2020
added 2 commits
April 30, 2020 16:16
acelyc111
previously approved these changes
Apr 30, 2020
foreverneverer
approved these changes
May 8, 2020
acelyc111
approved these changes
May 8, 2020
neverchanje
approved these changes
May 8, 2020
neverchanje
added
the
type/config-change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is intend to add rate limit for fds.
For put operation, we can't send a file in small batches. Because
putContentinterface of fds will overwrite what was sent before for the same file. So we must send a file all at one batch. It will produce network burst.But for get operation this problem does not exist, because we get can file content in batches.
New configuration