This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
fix(meta): bind task_tracker for each task in meta server #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(shell): support resolve IP address in dsn/utility (XiaoMi#337)
feat: optimize tcmalloc release memory (XiaoMi#343)
neverchanje
changed the title
fix(tasking::enqueue): core dump occurs after policy_context/backup_service destructed
fix(task): core dump occurs after policy_context/backup_service destructed
Dec 3, 2019
neverchanje
changed the title
fix(task): core dump occurs after policy_context/backup_service destructed
fix(meta): bind task_tracker for each task in meta server
Dec 3, 2019
neverchanje
approved these changes
Dec 3, 2019
acelyc111
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is found in the unit test in #342.
In the unit test for HTTP interface of querying coldback policy, I send a fake_rpc to add a policy here.
After finishing my test,
a core dumped happened.
Here is the info of the core file:
Then we find line 723 lacking a tracker to track unfinished tasks.
After that, we resolve a bug according to this train of thought, which always happens in our general unit tests.
By adding a tracker here.