This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
rpc: minor refactoring on message_reader #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
qinzuoyan,
shengofsun,
acelyc111,
hycdong and
vagetablechicken
vagetablechicken
previously approved these changes
May 16, 2019
hycdong
reviewed
May 16, 2019
| @@ -68,10 +60,19 @@ class message_reader | |||
| // discard read data | |||
| void truncate_read() { _buffer_occupied = 0; } | |||
|
|
|||
| void consume_buffer(size_t sz) | |||
There was a problem hiding this comment.
https://github.com/XiaoMi/rdsn/blob/master/src/core/tools/common/dsn_message_parser.cpp#L80
你看这行代码，reader 读完数据之后把读完的 buffer 释放掉，怎么释放的？
reader->_buffer = buf.range(msg_sz);
reader->_buffer_occupied -= msg_sz;这段代码就是 repeat your code 的典型，consume_buffer 这个函数就是做的这个事情，后面重构可以把上面的代码用 consume_buffer 代替
reader->consume_buffer(msg_sz);
我这边后面的 PR 会用到这个函数。
There was a problem hiding this comment.
嗯，好的，blob的range函数支持传negative的参数（https://github.com/XiaoMi/rdsn/blob/3989922cd3a99c7ce357af8de2d504bd6a5dd1af/include/dsn/utility/blob.h#L115）
不知道有没有更通用的写法，另外加下注释吧
hycdong
approved these changes
May 16, 2019
vagetablechicken
approved these changes
May 16, 2019
10 tasks
24 tasks
neverchanje
pushed a commit
that referenced
this pull request
Jun 14, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要补充了 message_reader 的注释和单测，这个类是一个错误的设计被放在一个正确的地方。
它本质上是用来从数据流中读入数据的，和 message 没有关系，却被叫做 message_reader。
它可以类比 sofa-pbrpc readbuffer 或者 brpc IOBuf，但实现非常粗糙，会产生较多内存拷贝，后续可以在此处进行优化。
rpc_write_stream 删除了一个构造函数，这个构造函数会造成内存泄漏，好在我们没有使用到它。