This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
valgrind: use function-local initialization to implement singleton #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
shengofsun,
qinzuoyan,
acelyc111,
hycdong,
mentoswang,
vagetablechicken and
zhangyifan27
shengofsun
reviewed
Oct 15, 2018
| static std::atomic<int> _l; | ||
|
|
||
| private: | ||
| singleton(const singleton &); |
There was a problem hiding this comment.
nocopyable的feature没了。毕竟这是个utility库，我们还是严谨些吧。
qinzuoyan
previously approved these changes
Oct 16, 2018
acelyc111
reviewed
Oct 16, 2018
include/dsn/utility/singleton.h
Outdated
| * xxxx-xx-xx, author, first version | ||
| * xxxx-xx-xx, author, fix bug about xxx | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <mutex> | ||
| #include <atomic> |
acelyc111
approved these changes
Oct 16, 2018
qinzuoyan
approved these changes
Oct 16, 2018
shengofsun
approved these changes
Oct 16, 2018
vagetablechicken
pushed a commit
to vagetablechicken/rdsn
that referenced
this pull request
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind warns that the internal pointer of singleton is not deleted (
singleton::_instance), to fix this we rewrite the singleton implementation.function-local initialization: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2660.htm#Local
See this if performance issue is your concern: https://stackoverflow.com/questions/23829389/does-a-function-local-static-variable-automatically-incur-a-branch?noredirect=1&lq=1