This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
replication: add is_idempotent attr for task code; add allow_non_idem… #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…potent_write in replication option
shengofsun
reviewed
Jul 9, 2018
| @@ -162,11 +163,16 @@ class task_code | |||
| // Notice we dispatch storage rpc's response to THREAD_POOL_DEFAULT, | |||
| // the reason is that the storage rpc's response mainly runs at client side, which is not | |||
| // necessary to start so many threadpools | |||
| #define DEFINE_STORAGE_RPC_CODE(x, pri, pool, is_write, allow_batch) \ | |||
| #define DEFINE_STORAGE_RPC_CODE(x, pri, pool, is_write, allow_batch, is_idempotent) \ | |||
| @@ -41,8 +41,8 @@ namespace replication { | |||
| namespace application { | |||
|
|
|||
| DEFINE_STORAGE_READ_RPC_CODE(RPC_SIMPLE_KV_SIMPLE_KV_READ) | |||
| DEFINE_STORAGE_WRITE_RPC_CODE(RPC_SIMPLE_KV_SIMPLE_KV_WRITE, true) | |||
| DEFINE_STORAGE_WRITE_RPC_CODE(RPC_SIMPLE_KV_SIMPLE_KV_APPEND, true) | |||
| DEFINE_STORAGE_WRITE_RPC_CODE(RPC_SIMPLE_KV_SIMPLE_KV_WRITE, true, true) | |||
| @@ -256,6 +257,11 @@ void replication_options::initialize() | |||
| "empty_write_disabled", | |||
| empty_write_disabled, | |||
| "whether to disable empty write, default is false"); | |||
| allow_non_idempotent_write = | |||
There was a problem hiding this comment.
这个option用tudo或者issue追踪一下，表示这是一个临时方案
shengofsun
approved these changes
Jul 10, 2018
hycdong
approved these changes
Jul 10, 2018
acelyc111
approved these changes
Jul 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…potent_write in replication option