feat(hotkey): Change RPC to query hotkey (#700)

XiaoMi · Dec 24, 2020 · 29c6ccc · 29c6ccc
1 parent ba19d04
commit 29c6ccc
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 8 deletions.
diff --git a/include/dsn/dist/replication/replication_types.h b/include/dsn/dist/replication/replication_types.h
diff --git a/src/common/replication_types.cpp b/src/common/replication_types.cpp
diff --git a/src/replica/replica_stub.cpp b/src/replica/replica_stub.cpp
@@ -2788,7 +2788,6 @@ void replica_stub::on_group_bulk_load(group_bulk_load_rpc rpc)
     }
 }
 
-// TODO: (Tangyanzhao) implement it later
 void replica_stub::on_detect_hotkey(detect_hotkey_rpc rpc)
 {
     const auto &request = rpc.request();

diff --git a/src/replication.thrift b/src/replication.thrift
@@ -1144,7 +1144,8 @@ enum hotkey_type
 enum detect_action
 {
     START,
-    STOP
+    STOP,
+    QUERY
 }
 
 enum disk_migration_status {
@@ -1167,6 +1168,7 @@ struct detect_hotkey_response {
     // - ERR_SERVICE_ALREADY_EXIST: hotkey detection is running now
     1: dsn.error_code err;
     2: optional string err_hint;
+    3: optional string hotkey_result;
 }
 
 /*
-Original file line number
+Diff line change
@@ Expand Up @@
         }
     }
-    // TODO: (Tangyanzhao) implement it later
     void replica_stub::on_detect_hotkey(detect_hotkey_rpc rpc)
     {
         const auto &request = rpc.request();
@@ Expand Down @@