shell: command `ls` and `nodes` support output in json mode #290

acelyc111 · 2019-02-25T15:20:36Z

Add an extra flag -j for command ls and nodes. Output with -j looks like:

>>> ls -d -j
{
    "general_info": {                     // section name
        "1": {                                       // key "1" is app id
            "app_id": "1",
            "status": "AVAILABLE",
            "app_name": "test",
            "app_type": "pegasus",
            "partition_count": "8",
            "replica_count": "3",
            "is_stateful": "true",
            "create_time": "-",
            "drop_time": "-",
            "drop_expire": "-",
            "envs_count": "0"
        },
        "2": {
            "app_id": "2",
            "status": "AVAILABLE",
            "app_name": "analysis_log",
            "app_type": "pegasus",
            "partition_count": "4",
            "replica_count": "3",
            "is_stateful": "true",
            "create_time": "-",
            "drop_time": "-",
            "drop_expire": "-",
            "envs_count": "0"
        },
        ...
    },
    "summary": {
        "total_app_count": "184",
        "fully_healthy_app_count": "184",
        "unhealthy_app_count": "0",
        "write_unhealthy_app_count": "0",
        "read_unhealthy_app_count": "0"
    }
}

>>> nodes -d -j
{
    "details": {
        "<ip>:<port>": {
            "address": "<ip>:<port>",
            "status": "ALIVE",
            "replica_count": "256",
            "primary_count": "101",
            "secondary_count": "155"
        },
        "<ip>:<port>": {
            "address": "<ip>:<port>",
            "status": "ALIVE",
            "replica_count": "265",
            "primary_count": "99",
            "secondary_count": "166"
        },
        ...
    },
    "summary": {
        "total_node_count": "10",
        "alive_node_count": "10",
        "unalive_node_count": "0"
    }
}

qinzuoyan · 2019-02-26T15:47:54Z

在空行、分段这些细节上还需要改进，目前的打印结果层次不太清晰，譬如：

>>> nodes

details
address              status  
10.38.161.207:31801  ALIVE   
10.38.161.244:31801  ALIVE   
10.38.162.227:31801  ALIVE   
10.38.162.236:31801  ALIVE   
10.38.166.24:31801   ALIVE   
10.38.166.28:31801   ALIVE   
10.38.166.81:31801   ALIVE   
10.38.166.82:31801   ALIVE   
10.38.166.83:31801   ALIVE   
10.38.166.93:31801   ALIVE   
summary
total_node_count    : 10
alive_node_count    : 10
unalive_node_count  : 0 

>>>

src/shell/commands/node_management.cpp

src/shell/commands/table_management.cpp

acelyc111 · 2019-02-27T08:44:39Z

在空行、分段这些细节上还需要改进，目前的打印结果层次不太清晰，譬如：

>>> nodes

details
address              status  
10.38.161.207:31801  ALIVE   
10.38.161.244:31801  ALIVE   
10.38.162.227:31801  ALIVE   
10.38.162.236:31801  ALIVE   
10.38.166.24:31801   ALIVE   
10.38.166.28:31801   ALIVE   
10.38.166.81:31801   ALIVE   
10.38.166.82:31801   ALIVE   
10.38.166.83:31801   ALIVE   
10.38.166.93:31801   ALIVE   
summary
total_node_count    : 10
alive_node_count    : 10
unalive_node_count  : 0 

>>>

fixed

qinzuoyan · 2019-02-28T06:55:53Z

为了显示清晰，不同的section之间最好用空行分隔，譬如下面就没有：

>>> nodes
[details]
address              status  
10.239.35.224:34801  ALIVE   
10.239.35.224:34802  ALIVE   
10.239.35.224:34803  ALIVE   
[summary]
total_node_count    : 3
alive_node_count    : 3
unalive_node_count  : 0

acelyc111 · 2019-03-01T09:21:57Z

为了显示清晰，不同的section之间最好用空行分隔，譬如下面就没有：

>>> nodes
[details]
address              status  
10.239.35.224:34801  ALIVE   
10.239.35.224:34802  ALIVE   
10.239.35.224:34803  ALIVE   
[summary]
total_node_count    : 3
alive_node_count    : 3
unalive_node_count  : 0

这得统一改rdsn,这个PR就不特殊处理了

neverchanje · 2019-03-04T06:46:49Z

scripts/py_utils/lib.py

+        nodes_detail = self._run_shell("nodes -d -j").strip()
+
+        primaries_per_node = {}
+        min_ = 0


这里为什么多加了下划线

min是库函数...

qinzuoyan · 2019-03-04T06:49:57Z

为了显示清晰，不同的section之间最好用空行分隔，譬如下面就没有：
>>> nodes
[details]
address              status  
10.239.35.224:34801  ALIVE   
10.239.35.224:34802  ALIVE   
10.239.35.224:34803  ALIVE   
[summary]
total_node_count    : 3
alive_node_count    : 3
unalive_node_count  : 0
这得统一改rdsn,这个PR就不特殊处理了

现在rdsn也还没有提交，先一起都改好？

acelyc111 · 2019-03-04T07:36:45Z

为了显示清晰，不同的section之间最好用空行分隔，譬如下面就没有：
>>> nodes
[details]
address              status  
10.239.35.224:34801  ALIVE   
10.239.35.224:34802  ALIVE   
10.239.35.224:34803  ALIVE   
[summary]
total_node_count    : 3
alive_node_count    : 3
unalive_node_count  : 0
这得统一改rdsn,这个PR就不特殊处理了
现在rdsn也还没有提交，先一起都改好？

fixed

Former-commit-id: 4a78724131e5aadb4788693d81721a273cf934b7 [formerly 2d35dce] Former-commit-id: 3cab8745a7f36f33c787650e073694c61a1c67c2

acelyc111 and others added 4 commits February 25, 2019 23:12

shell: command ls, nodes support output in json mode.

a9ab7a1

code format

0c3f7df

Merge branch 'master' into CLI_table_output_json

8fee987

fix

2ddd983

qinzuoyan reviewed Feb 26, 2019

View reviewed changes

src/shell/commands/node_management.cpp Show resolved Hide resolved

src/shell/commands/table_management.cpp Show resolved Hide resolved

section name output with '[]' in tabluar mode

9d4aa60

acelyc111 added 2 commits February 27, 2019 16:45

Merge branch 'master' into CLI_table_output_json

542fed1

Merge branch 'master' into CLI_table_output_json

ba5c4d6

qinzuoyan assigned acelyc111 Feb 28, 2019

qinzuoyan added the component/shell pegasus shell label Feb 28, 2019

neverchanje reviewed Mar 4, 2019

View reviewed changes

qinzuoyan and others added 2 commits March 4, 2019 17:27

Merge branch 'master' into CLI_table_output_json

57cc1e5

update rdsn

835cdc8

qinzuoyan approved these changes Mar 4, 2019

View reviewed changes

neverchanje approved these changes Mar 4, 2019

View reviewed changes

Merge branch 'master' into CLI_table_output_json

ac46126

qinzuoyan merged commit 2d35dce into apache:master Mar 4, 2019

acelyc111 mentioned this pull request May 17, 2019

scripts: add pegasus_stat_cu.sh #328

Closed

neverchanje mentioned this pull request Jun 14, 2019

Release 1.12.0 #337

Closed

24 tasks

neverchanje pushed a commit that referenced this pull request Jun 14, 2019

shell: command ls and nodes support output in json mode (#290)

d38607f

neverchanje mentioned this pull request Jun 21, 2019

Release 1.11.5 #341

Closed

19 tasks

neverchanje pushed a commit that referenced this pull request Jun 21, 2019

shell: command ls and nodes support output in json mode (#290)

1700e82

neverchanje pushed a commit that referenced this pull request Jul 1, 2019

shell: command ls and nodes support output in json mode (#290)

7a30d5d

neverchanje added the release-note label Jul 5, 2019

neverchanje added the 1.11.5 label Sep 21, 2019

acelyc111 pushed a commit that referenced this pull request Jun 23, 2022

feat(http): support CPU profiling using gperf (#290)

4167057

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

shell: command `ls` and `nodes` support output in json mode #290

shell: command `ls` and `nodes` support output in json mode #290

acelyc111 commented Feb 25, 2019 •

edited

Loading

qinzuoyan commented Feb 26, 2019

acelyc111 commented Feb 27, 2019

qinzuoyan commented Feb 28, 2019

acelyc111 commented Mar 1, 2019 •

edited

Loading

neverchanje Mar 4, 2019

acelyc111 Mar 4, 2019

qinzuoyan commented Mar 4, 2019

acelyc111 commented Mar 4, 2019 •

edited

Loading

shell: command ls and nodes support output in json mode #290

shell: command ls and nodes support output in json mode #290

Conversation

acelyc111 commented Feb 25, 2019 • edited Loading

qinzuoyan commented Feb 26, 2019

acelyc111 commented Feb 27, 2019

qinzuoyan commented Feb 28, 2019

acelyc111 commented Mar 1, 2019 • edited Loading

neverchanje Mar 4, 2019

Choose a reason for hiding this comment

acelyc111 Mar 4, 2019

Choose a reason for hiding this comment

qinzuoyan commented Mar 4, 2019

acelyc111 commented Mar 4, 2019 • edited Loading

shell: command `ls` and `nodes` support output in json mode #290

shell: command `ls` and `nodes` support output in json mode #290

acelyc111 commented Feb 25, 2019 •

edited

Loading

acelyc111 commented Mar 1, 2019 •

edited

Loading

acelyc111 commented Mar 4, 2019 •

edited

Loading