This repository has been archived by the owner on May 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
fix: scanner.next() won't automatically recover when server side not return ERR_OK #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
previously approved these changes
Apr 29, 2021
levy5307
approved these changes
May 7, 2021
hycdong
approved these changes
May 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
next()
rpc not responseERR_OK
, it will mark_encounterError=true
, and all thenext()
loop will directly return error. so if server side occur transientERR_TIMEOUT
,ERR_SESSION_RESET
,ERR_OBJECT_NOT_FOUND
,ERR_INVALID_STATE
problem, it won't automatically recover after the server side recover. This pr resolve the fix when encounter the rpc failed.Manual Test
scan
taskERR_SESSION_RESET
and update config automaticallynext
rpc and receiveCONTEXT_ID_NOT_EXIST
for using new config, which will trigerasyncStartScan
with currenthashKey
andsortKey
as start indexset_meta_level=true
to rebalance the onebox clusterERR_INVALID_STATE
and update config automatically againnext
rpc and receiveCONTEXT_ID_NOT_EXIST
for using new config, which will trigerasyncStartScan
with currenthashKey
andsortKey
as start index