Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Get method takes a 32-bit integer, should be 64-bit #666

Closed
gkverneland opened this issue Nov 22, 2021 · 4 comments
Closed

The Get method takes a 32-bit integer, should be 64-bit #666

gkverneland opened this issue Nov 22, 2021 · 4 comments
Milestone

Comments

@gkverneland
Copy link

Referring to this issue: #615

This has not been fully fixed since the Get method still takes a 32-bit integer, while it should take a 64-bit integer since IDs can be for example 61000150083. Downloading a product with ID 61000150083 is still not possible.

@XiaoFaye XiaoFaye added this to the 0.8.5 milestone Nov 23, 2021
@XiaoFaye
Copy link
Owner

Thanks, this will be fixed in the next version ASAP.😂

@RoeiKO
Copy link

RoeiKO commented Dec 8, 2021

@XiaoFaye Hi
related_ids on the Product class should also be an Int64
{"JSON integer 50001672461251 is too large or small for an Int32. Path '[0].related_ids[0]', line 1, position 2561."}

@XiaoFaye
Copy link
Owner

XiaoFaye commented Dec 8, 2021

@RoeiKO Thanks for pointing out, will fix it in the next version.

@gkverneland
Copy link
Author

@XiaoFaye when are you planning to release the next version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants