Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing to Nginx Ingresses #668

Open
dachrillz opened this issue May 6, 2022 · 3 comments
Open

Add tracing to Nginx Ingresses #668

dachrillz opened this issue May 6, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@dachrillz
Copy link

dachrillz commented May 6, 2022

Nginx can support open telemetry style distributed tracing. We would like to add this functionality as this would increase the observability of the platform.

After some research it turns out that there might be some bugs with ingress-nginx and the open telemetry stack. This work can probably not continue until those issues are resolved.

Some things to consider,

  1. make sure that this does not add too much load to the system. Both performance and storage wise.
@dachrillz dachrillz added the enhancement New feature or request label May 6, 2022
@NissesSenap
Copy link
Contributor

There is currently issues with running otel in ingress-nginx, we can follow the issue here: open-telemetry/opentelemetry-cpp-contrib#141
kubernetes/ingress-nginx#8437

@NissesSenap
Copy link
Contributor

Just an update, there is still work ongoing in this area: kubernetes/ingress-nginx#8735
But it looks like it's getting closer and closer and hopefully we will be able to try this out in a month or two.

@landerss1
Copy link
Contributor

Looks like it's only a matter of adding the correct configuration to the opentelemetry attribute in the chart: https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml#L709C3-L709C16. This should only be done for unbox clusters where we are actually using tracing, so the ingress-nginx module should be extended with the extra config variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants