Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button color change on row select. #109

Open
Kamik423 opened this issue Feb 20, 2021 · 1 comment
Open

Button color change on row select. #109

Kamik423 opened this issue Feb 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Kamik423
Copy link

Kamik423 commented Feb 20, 2021

When using arrow keys to select a row the blue (OPEN) button will immediately turn white. But using the mouse will have a short lag which looks suboptimal and weird.

EDIT: Additionally it also looks a bit confusing how blue and white buttons are white when selected. I guess this should somehow be changed, too.

Screen.Recording.2021-02-20.at.22.37.22.mov

Version

  • OS: 11.2 (20D64)
  • Xcodes: 1.0.3
@Kamik423 Kamik423 added the bug Something isn't working label Feb 20, 2021
@interstateone
Copy link
Contributor

Thanks @Kamik423, this was another SwiftUI.List thing that I wasn't able to figure out. The way selection behaves in NSTableView is generally "nicer", and for some reason when I tried to replicate the color updating, the SwiftUI.List selection state is updated on mouse up instead of mouse down. Like #96, I'd be curious to see if there's a way to achieve better behaviour while continuing to use SwiftUI.List, but this might have to wait for an improvement in the framework.

Additionally it also looks a bit confusing how blue and white buttons are white when selected. I guess this should somehow be changed, too.

If you feel strongly about this can you please open a separate ticket and elaborate on what you'd prefer to see instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants