-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MiniCart: title inconsistency #209
Comments
As of v2.2 this is still the case. Additional notes: the minicart is created based on a freemarker template in the html and that is only loaded on page load. The template sets the title to "item" if there is exactly 1 item in the cart if there are more or less items in there it uses the default line with "items" since that ("0 items in cart") would be the correct way to say it. The dynamic add to cart that shows the minicart pop up and makes it update without a reload is based on JavaScript and AJAX. We currently do not test in this script how many products in the cart the performed operation is going to result in and accordingly can't adjust the text. If requested this should not be complicated to implement but comes at a slight cost for performance. |
This ticket is a duplicate of already existing ticket #129 |
Issue 1: Wrong MiniCart title after adding item to empty cart.
Reproduce:
When adding a new item to an empty shopping cart, the title of the MiniCart will be displayed wrongly by saying "1 ITEMS IN CART":
![1](https://private-user-images.githubusercontent.com/65414932/260416228-91038c0e-a67d-42f0-95c6-be5b2769d86e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjI1MTUsIm5iZiI6MTczOTY2MjIxNSwicGF0aCI6Ii82NTQxNDkzMi8yNjA0MTYyMjgtOTEwMzhjMGUtYTY3ZC00MmYwLTk1YzYtYmU1YjI3NjlkODZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIzMzAxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjYWYwNTkxMzkxYjEzNmYwZTQ1MDliNDk3ZTMxZGM2MDNlZTI0NmIwZjgwZjY2MjI0MmJmYzA4YmRhOGU2YWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KQYsZrBIdty1V2UNT-9l79PSUcFnYu6OO80IfwP-ooE)
![2](https://private-user-images.githubusercontent.com/65414932/260416229-1a67fc62-a5bd-4d07-8211-be31492448d2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjI1MTUsIm5iZiI6MTczOTY2MjIxNSwicGF0aCI6Ii82NTQxNDkzMi8yNjA0MTYyMjktMWE2N2ZjNjItYTViZC00ZDA3LTgyMTEtYmUzMTQ5MjQ0OGQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIzMzAxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmNmQ1ZGM5YjE4NGZkNDMzMjZlMzhkN2FlNGVjZDhjNWY2YzE4ZjdiM2VlNzA3YzdhNDQ4ZGQ0YzQ3MDk4MTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.tF1o1470rxvHwcC3-f4_PYOMJSxqxxhuULSVTkda2js)
Only after updating the page by for example going to the CartPage, the title of the MiniCart will be displayed correctly:
Issue 2: Wrong MiniCart title after changing the quantity of a specific item on CartPage.
Reproduce:
When changing the quantity of an item on the CartPage to something bigger than 1, the title of the MiniCart will be displayed wrongly by saying "5 ITEM IN CART":
![3](https://private-user-images.githubusercontent.com/65414932/260416231-3243bc52-7435-4444-817e-e0049cb6d653.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjI1MTUsIm5iZiI6MTczOTY2MjIxNSwicGF0aCI6Ii82NTQxNDkzMi8yNjA0MTYyMzEtMzI0M2JjNTItNzQzNS00NDQ0LTgxN2UtZTAwNDljYjZkNjUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIzMzAxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4ODEzMzQyNDc3M2Y0MTUwZDA0MmQwODUwZWQwNWNlMWM2Mzk0ZTY5NWI4YjM0M2EyZjVkODVkNzM5NmRjNjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.1QcPocQma0mkyQHKCZ3is5ctczBMCZWAVwOWawoS0Ow)
![4](https://private-user-images.githubusercontent.com/65414932/260416234-4752b365-edd8-4943-9024-85b8f5ab8e54.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjI1MTUsIm5iZiI6MTczOTY2MjIxNSwicGF0aCI6Ii82NTQxNDkzMi8yNjA0MTYyMzQtNDc1MmIzNjUtZWRkOC00OTQzLTkwMjQtODViOGY1YWI4ZTU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIzMzAxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNhNDFmOWE3OWU0OTkyMzUyNzNlODY2MzRiZmU3NDAyM2RmMGU3ZGEyNzMyN2IyMTE3MjQxZDVlZTEyNWIzMmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.M52qMitLamUExcYgxrQ7smI-ll1UK7ScWmVlWpeJZfA)
Only updating the page fixes that issue as well. After going to any CategoryPage for example, the title of the MiniCart will then be displayed correctly:
The text was updated successfully, but these errors were encountered: