Commenting out expressions doesn't work as expected #65
Comments
|
I think that {{!-- }} comments are not supported at all; only {{! expression }} style comments are supported. I think this should be implemented in |
|
@jslegers the original comments syntax is In your last example anything after the first I believe that Handlebars.php behavior is correct and correspond to Handlebars.js behavior. |
|
Handlebars.js allows comments that contain handlebar tokens with the |
|
+1 for comments. |
It's unclear to me whether it's possible to comment out expressions and have handlebars.php completely ignore anything in a comment, which is possible in pretty much every programming language and commonly used for temporarily storing deleted code that may be fully or partially restored at a later time.
Currently, handlebars.php tries to parse any
{{ }}it can find as an expression, including those within comments. This results in a fatal error when no helper can be found with that name.That means I can't do this :
This also doesn't work :
{{!-- comment}} <html> <body>Hello {{name}}</br> You have just won ${{value}}!</br> {{#in_ca}} Well, ${{taxed_value}}, after taxes.</br> {{/in_ca}} </body> </html> {{comment --}}This doesn't work either :
{{!-- <html> <body>Hello {{name}}</br> You have just won ${{value}}!</br> {{#in_ca}} Well, ${{taxed_value}}, after taxes.</br> {{/in_ca}} </body> </html> --}}Neither does this :
{{!-- <html><body>Hello {{name}}</br>You have just won ${{value}}!</br>{{#in_ca}}</br>Well, ${{taxed_value}}, after taxes.{{/in_ca}}</body></html> --}}Whatever I try, I keep getting the following error :
This isn't how I expect comments to work.
The text was updated successfully, but these errors were encountered: