Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow xApp opening in browser #5

Open
WietseWind opened this issue May 16, 2023 · 2 comments
Open

Do not allow xApp opening in browser #5

WietseWind opened this issue May 16, 2023 · 2 comments
Assignees
@KoenPaas

Comments

@WietseWind
Copy link
Member

Pathfinding is an xApp and should not open in the browser in the first place. Thing to fix here is that the xApp shouldn't allow for opening in the browser where no Xumm user agent is present. I'll add an issue on Github for when Koen is back from a few days off this week

image
@WietseWind
Copy link
Member Author

https://monkdesk.xrpl-labs.com/agent/ticket/70513

@WietseWind
Copy link
Member Author

Simply redirect to here: https://xumm.app/detect/xapp:xumm.pathfinding if no xumm in the user agent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KoenPaas KoenPaas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WietseWind @KoenPaas