Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for PKCE browser flow for non SignIn TX types #12

Open
WietseWind opened this issue Dec 10, 2024 · 2 comments
Open

Allow for PKCE browser flow for non SignIn TX types #12

WietseWind opened this issue Dec 10, 2024 · 2 comments

Comments

@WietseWind
Copy link
Member

Will work on this in due time :) Great idea!

image

@tequdev

@WietseWind
Copy link
Member Author

Implementation:

Integrate alternative TX template for OAUTH platform, and then integrate in PKCE, and then update in Universal SDK
https://github.com/XRPL-Labs/XummPkce/blob/main/src/index.ts

@WietseWind
Copy link
Member Author

We can actually re-use OAUTH2 platform,

https://oauth2.xumm.app/auth?response_type=token&client_id=xxx&state=yyy&scope=XummPkce&redirect_uri=zzz

... Already supports:
&force_network=XAHAU
signers=rwietsevLFg8XSmG3bEZzFein1g8RBqWDZ,rTeLeproT3BVgjWoYrDYpKbBLXPaVMkge

... We can add txhex / ... as extra param and use that in the OAuth sign flow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant