Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] (PRIO!) Dynamic Flags based on server definitions #492

Open
WietseWind opened this issue Apr 1, 2024 · 2 comments
Open

[Feature] (PRIO!) Dynamic Flags based on server definitions #492

WietseWind opened this issue Apr 1, 2024 · 2 comments
Assignees
Labels
PRIO1 High Prio (Confusing / Security)

Comments

@WietseWind
Copy link
Member

Based on the proposal to include flag numbers in RPC Server Definitions calls:

... TX details, sign requests, etc. should display the Flag names corresponding to the network the transaction happened on / is about to happen on.

Currently when someone tries to set / remove Flag 16 on their account, no matter if connected to XRPL or Xahau, it is displayed as asfAllowTrustLineClawback, while on Xahau this flag means asfDisallowIncomingRemit.

@RichardAH / @dangell7 & then @N3TC4T this has prio, because we're currently showing the wrong information to signers. Let's add this both to the next version of Xahaud (RPC, no consensus, so no amendment needed) & Xaman, and PR to XRPL.

@WietseWind
Copy link
Member Author

image

@WietseWind
Copy link
Member Author

Going to be released in days, so we can include this :)

@N3TC4T N3TC4T added this to Xaman App May 10, 2024
@N3TC4T N3TC4T moved this to 3.0 - Done / To Test in Xaman App May 10, 2024
@github-project-automation github-project-automation bot moved this to 3.0 - Done / To Test in XUMM 2.2-2.X Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIO1 High Prio (Confusing / Security)
Projects
Status: 3.0 - Done / To Test
Status: Done / To Test
Development

No branches or pull requests

4 participants