Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2: custom network: valid signers not updated after switching networks #137

Closed
WietseWind opened this issue Jan 13, 2025 · 1 comment
Closed
Milestone

Comments

@WietseWind
Copy link
Member

Steps to reproduce:

be on custom network
have two or more full access accounts: eg rA and rB
have selected account rA in xaman
make request to do some tx with signer "rB"
xaman shows "No signers available"
Fixed when i switched accounts ra rb and back, it seems xaman did not "cached/loaded" those accounts yet to app. I suggest following fallback: when sign tx is shown and it would want to show "no available signers" message, do another "live check" to see if accounts are there.


Hunch:

  • After switching the account status isn't updated as known activated?
@WietseWind WietseWind added this to the 3.3 milestone Jan 13, 2025
@N3TC4T
Copy link
Member

N3TC4T commented Jan 17, 2025

Fixed in c878ca8

Reverted the changes that only updated the active account. Now, all account details will be updated whenever the app connects to the network or the network is switched within the app.

Additionally, I updated the list of accounts eligible to sign a payload. All accounts with signing capability, regardless of activation status, will now be available for signing a payload, A live check will be performed before signing the payload. This will resolve the issue where a user is forced to switch to another network while signing the payload, but the app has never connected to that network before. In such cases, no account information would be available, and the app would incorrectly consider the accounts as not activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants