Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prio] Addition: Hook Explainer frame: also on Sign Request #133

Open
WietseWind opened this issue Dec 30, 2024 · 1 comment
Open

[Prio] Addition: Hook Explainer frame: also on Sign Request #133

WietseWind opened this issue Dec 30, 2024 · 1 comment
Labels
Prio Important
Milestone

Comments

@WietseWind
Copy link
Member

Currently, the Hook Explainer Frame opens on:

  • Hook enabled network
  • Event list tx details
  • HookSet tx

As all transactions can now involve Hook execution, it should display on ALL transactions (because there could be an outgoing Hook involved) on networks with Hooks enabled.

At first I only thought to add it to Invoke TX and anything With Hook params, but it can actually be ANY tx. So let's ALWAYS show it right before the slide button. The frame will be 0px height on by default and the inner frame will scale/size it with the existing logic to resize the webview.

@WietseWind WietseWind added the Prio Important label Jan 7, 2025
@WietseWind WietseWind added this to the 3.3 milestone Jan 8, 2025
@N3TC4T
Copy link
Member

N3TC4T commented Jan 17, 2025

Added b75ed5c

Note: as we use the hook explainer in different part of the app, I included a field called origin to the post data to the explainer endpoint.

Possible values is TransactionDetails and ReviewPayload indicating that HookExplainer is being displayed in the transaction details or in the review transaction before signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio Important
Projects
None yet
Development

No branches or pull requests

2 participants