New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid colon as first character in XML identifiers #630

Closed

lognaturel opened this issue Nov 21, 2022 · 1 comment · Fixed by #736

Milestone

Contributor

lognaturel commented Nov 21, 2022 •

edited

Loading

Colons are currently allowed as the first character of XML identifiers: https://github.com/XLSForm/pyxform/blob/master/pyxform/xlsparseutils.py#L8

This is consistent with https://www.w3.org/TR/REC-xml/#NT-NameStartChar but doesn't really make sense in real usage as described at https://stackoverflow.com/a/40446164/137744

We should probably forbid colons in the identifiers at all since we don't really support namespacing of body elements (#105 (comment)).

Contributor Author

lognaturel commented Jan 26, 2023

Validate doesn't allow leading colons anyway so we really should update the message and logic.

lognaturel added this to the Next milestone

lindsay-stevens mentioned this issue

647: include all choice lists in output #736

Merged

4 tasks

lindsay-stevens closed this as completed in #736

lognaturel mentioned this issue

Update identifier validation message now that leading colons aren't allowed #747

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment