Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage is ambiguous for peaklets-uhfusstvab in straxen 1.2.0 and 1.2.1 #875

Closed
JoranAngevaare opened this issue Jan 10, 2022 · 0 comments · Fixed by #873 or #825
Closed

Lineage is ambiguous for peaklets-uhfusstvab in straxen 1.2.0 and 1.2.1 #875

JoranAngevaare opened this issue Jan 10, 2022 · 0 comments · Fixed by #873 or #825
Labels
bug Something isn't working

Comments

@JoranAngevaare
Copy link
Contributor

JoranAngevaare commented Jan 10, 2022

Bug for peaklets-uhfusstvab

In #825 the version of peaklets was not bumped. This causes an issue for peaklets-uhfusstvab since this hash refers to to types of data with and without the updated tight coincidence field.

Manifestation

If one loads data with straxen 1.2.0 or 1.2.1 from earlier straxen versions. Strax will raise errors since the dtype is not as expected:

strax.plugin.PluginGaveWrongOutput: Plugin MergedS2s did not deliver data type merged_s2s as promised.
Promised:  [('time', '<i8'), ('length', '<i4'), ('dt', '<i4'), ('channel', '<i2'), ('type', 'i1'), ('area', '<f4'), ('area_per_channel', '<f4', (494,)), ('n_hits', '<i4'), ('data', '<f4', (200,)), ('width', '<f4', (11,)), ('area_decile_from_midpoint', '<f4', (11,)), ('saturated_channel', 'i1', (494,)), ('n_saturated_channels', '<i2'), ('tight_coincidence', '<i2'), ('max_gap', '<i4'), ('max_goodness_of_split', '<f4')]
Delivered: [('time', '<i8'), ('length', '<i4'), ('dt', '<i4'), ('channel', '<i2'), ('type', 'i1'), ('area', '<f4'), ('area_per_channel', '<f4', (494,)), ('n_hits', '<i4'), ('data', '<f4', (200,)), ('width', '<f4', (11,)), ('area_decile_from_midpoint', '<f4', (11,)), ('saturated_channel', 'i1', (494,)), ('n_saturated_channels', '<i2'), ('tight_coincidence', '<i2'), ('tight_coincidence_channel', '<i2'), ('max_gap', '<i4'), ('max_goodness_of_split', '<f4')].

Similarly if one loads data created with straxen 1.2.0 or 1.2.1 in older straxen versions, a similar error will occur.

Fix

#873 fixed this issue. Reflected in straxen >=v1.2.2

@JoranAngevaare JoranAngevaare added the bug Something isn't working label Jan 10, 2022
@JoranAngevaare JoranAngevaare changed the title Lineage is abigous for peaklets-uhfusstvab in straxen 1.2.0 and 1.2.1 (peaklets-uhfusstvab) Lineage is ambiguous for pellets-uhfusstvab in straxen 1.2.0 and 1.2.1 Jan 10, 2022
@JoranAngevaare JoranAngevaare changed the title Lineage is ambiguous for pellets-uhfusstvab in straxen 1.2.0 and 1.2.1 Lineage is ambiguous for peaklets-uhfusstvab in straxen 1.2.0 and 1.2.1 Jan 10, 2022
This was linked to pull requests Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant