Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to trust #122

Merged
merged 3 commits into from
May 6, 2017
Merged

Conversation

alexeyzab
Copy link
Contributor

These changes configure the trust template to use the correct
credentials and project name.

This is an initial pass at setting up the new CI. If there are any
addition tweaks that need to be done here, let me know.

Thanks!

#120

@XAMPPRocky
Copy link
Owner

Thank you for the PR! The nightly channels seem to be consistently failing to build. Could you have a look at why?

@alexeyzab
Copy link
Contributor Author

@Aaronepower Sure! It seems to be a recent issue with rustup: rust-lang/rustup#1092. I'll keep checking till it gets resolved.

@alexeyzab
Copy link
Contributor Author

alexeyzab commented May 5, 2017

I've enabled allow_failures for nightly builds on travis-ci. I keep trying to get the same option to work for appveyor, but I think I am messing up the config file somehow. Sorry about that.

EDIT: if the CI tests pass, I'll do a rebase and squash all these commits to clean it up a bit.

These changes configure the trust template to use the correct
credentials and project name. The rest was left as is.

There seems to be an issue with rustup at the moment
rust-lang/rustup#1092. As suggested in
rust-lang/rustup#1092 (comment)
I've enabled the `allow_failures` feature for nightly builds.
@alexeyzab alexeyzab force-pushed the move-ci-to-trust branch from 3725ac2 to 3291ed9 Compare May 5, 2017 14:58
@XAMPPRocky
Copy link
Owner

This looks great! Could you also add a beta channel, so we can know ahead of time if tokei has a soundness bug or anything similar before it hits stable.

@alexeyzab
Copy link
Contributor Author

Done. Let me know if there is anything else I can help with here.

@XAMPPRocky
Copy link
Owner

@alexeyzab Sorry, we want betas to give us an error on failure. I'm also not seeing any beta builds in either travis or appveyor?

@alexeyzab
Copy link
Contributor Author

@Aaronepower My bad, I'll look into that.

@alexeyzab
Copy link
Contributor Author

I've added beta channels back in for both travis and appveyor. I took all the targets from the old .travis.yml.

@XAMPPRocky XAMPPRocky merged commit d6910d1 into XAMPPRocky:master May 6, 2017
@XAMPPRocky
Copy link
Owner

Thank you!

@alexeyzab alexeyzab deleted the move-ci-to-trust branch May 6, 2017 02:41
@XAMPPRocky XAMPPRocky mentioned this pull request May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants