Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AML does not honour ESC key #332

Open
Csimbi opened this issue Oct 31, 2022 · 1 comment
Open

AML does not honour ESC key #332

Csimbi opened this issue Oct 31, 2022 · 1 comment
Labels
Status: Implemented Indicates that the issue has been handled but may not have been merged. Type: Enhancement
Milestone
v1.6

Comments

@Csimbi
Copy link

Csimbi commented Oct 31, 2022

AML Version: 1.5

Description
The ESC key is the defacto "I changed my mind" shortcut in Windows applications.
Yet, AML does not recognize it - none of the dialogs close and 'Cancel' must be clicked manually.
Making people reach for the mouse in frowned upon by many.
Please make sure AML reacts to the ESC key correctly.
Thank you!

Attachments
None
@Csimbi Csimbi added Status: Review Verify bug or check feasibility of a new feature. Type: Bug labels Oct 31, 2022
@RevZero RevZero added Type: Enhancement Status: Accepted Confirmed bug or useful feature that should be worked on. and removed Type: Bug Status: Review Verify bug or check feasibility of a new feature. labels Oct 31, 2022
@RevZero
Copy link
Member

RevZero commented Oct 31, 2022

Good suggestion. Should make it into next release.

RevZero added a commit to RevZero/xcom2-launcher that referenced this issue Aug 17, 2023
@RevZero
Fixes X2CommunityCore#332
28143cd 
- All dialogs can now be closed by pressing the escape key.
- The initial WelcomeDialog can now be properly "canceled" as well, effectively closing AML. Until now, it was possible to skip the dialog by pressing ALT+F4 and AML continued with default values.
- Added "Close" button to some dialogs for consistency.
@RevZero RevZero added Status: In Progress Someone is working on this or has been assigned. and removed Status: Accepted Confirmed bug or useful feature that should be worked on. labels Aug 17, 2023
@RevZero RevZero added this to the v1.6 milestone Aug 17, 2023
@RevZero RevZero mentioned this issue Aug 17, 2023
Closed
RevZero added a commit to RevZero/xcom2-launcher that referenced this issue Aug 17, 2023
@RevZero
Fixes X2CommunityCore#332
5511b77 
- All dialogs can now be closed by pressing the escape key.
- The initial WelcomeDialog can now be properly "canceled" as well, effectively closing AML. Until now, it was possible to skip the dialog by pressing ALT+F4 and AML continued with default values.
- Added "Close" button to some dialogs for consistency.
- Dispose all dialogs properly.
@RevZero RevZero linked a pull request Aug 17, 2023 that will close this issue
Fixes #332 #351
Closed
RevZero pushed a commit that referenced this issue Aug 18, 2023
@remcoros
Dialog usability improvements (#353)
f19b15f 
- All dialogs can now be closed by pressing the escape key. Fixes #332.
- Enter key can now be used to close/confirm dialogs as well.
- Added "Close" button to some dialogs for consistency.
- The initial WelcomeDialog can now be properly "canceled" as well, effectively closing AML. Until now, it was possible to skip the dialog by pressing ALT+F4 and AML continued with default values.
- Dispose all dialogs properly.
- Remove Compare button in ConfigDiff dialog, it served no purpose.

---------
Co-authored-by: RevZero <[email protected]>
@RevZero RevZero added Status: Implemented Indicates that the issue has been handled but may not have been merged. and removed Status: In Progress Someone is working on this or has been assigned. labels Aug 18, 2023
RevZero added a commit that referenced this issue Jul 5, 2024
@RevZero
Dialog usability improvements (#353)
9386f38 
- All dialogs can now be closed by pressing the escape key. Fixes #332.
- Enter key can now be used to close/confirm dialogs as well.
- Added "Close" button to some dialogs for consistency.
- The initial WelcomeDialog can now be properly "canceled" as well, effectively closing AML. Until now, it was possible to skip the dialog by pressing ALT+F4 and AML continued with default values.
- Dispose all dialogs properly.
- Remove Compare button in ConfigDiff dialog (was always disabled).

---------
Co-authored-by: Remco Ros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Implemented Indicates that the issue has been handled but may not have been merged. Type: Enhancement
Projects
None yet
Milestone
v1.6
Development

Successfully merging a pull request may close this issue.

Fixes #332 RevZero/xcom2-launcher
2 participants
@RevZero @Csimbi