Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAL_1 as written is the only MATH routine that requires BASIC ZP to be intact #240

Open
mooinglemur opened this issue Dec 18, 2023 · 1 comment
Labels
[BASIC] enhancement New feature or request [MATH] priority-low Low priority. Ok if not completed.

Comments

@mooinglemur
Copy link
Collaborator

This issue is being opened so that we can revisit later if we want to refactor VAL_1 so that it doesn't use any BASIC ZP.

@irmen
Copy link
Contributor

irmen commented Dec 29, 2023

Here's some more info on why the current implementation is a bit problematic: commanderx16/x16-rom#242 (comment)

In this blog post https://www.pagetable.com/?p=774 there's a link to the M6502.MAC source file that seems to include some form of float input code. Search for "FLOATING POINT INPUT ROUTINE". You can see it calls CHRGET, which is the main problem. So this code can't be used but at least it is commented as to what it is doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[BASIC] enhancement New feature or request [MATH] priority-low Low priority. Ok if not completed.
Projects
None yet
Development

No branches or pull requests

2 participants