Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instanced Scenery Object Export Type is severly lacking in validations #368

Open
4 tasks
tngreene opened this issue Aug 8, 2018 · 0 comments
Open
4 tasks

Comments

@tngreene
Copy link
Contributor

tngreene commented Aug 8, 2018

Upon close inspection it appears that multiple versions of the Instanced Scenery Object Export idea are being broken

  • Animations are allowed
  • Material ATTRs of different classes allowed, when normally they're only allowed if solid
  • Material ATTRs of certain classes are allowed anyway
  • Probably more.

We do some self consistent error checking validating ourselves and comparing reference materials in xplane_material_utils.py (see compareInstanced and validateInstanced)

Very few unit tests cover this feature.

These cover if instance materials with certain properties pass

  • instanced.test.blend
  • IST_2Mats_SameSPEC_DifSURF.test.blend
  • IST_2mats_wDraping.test.blend

These cover if instance materials with certain properties fails (not the same spectacular)

  • IST_2mats_VarSPEC.test.blend

More Reading

Developer Blog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant